linux-kernel - Re: [GIT PULL] KVM changes for 3.16-rc4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyLk1AWxd9r2zfrKtpawPhw53k_rBdj8kq159i=hf6xsA@mail.gmail.com>
Date:	Tue, 1 Jul 2014 10:47:55 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Gleb Natapov <gleb@...nel.org>, KVM list <kvm@...r.kernel.org>
Subject: Re: [GIT PULL] KVM changes for 3.16-rc4

On Tue, Jul 1, 2014 at 3:44 AM, Paolo Bonzini <pbonzini@...hat.com> wrote:
>
>   git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus

I've pulled this, but I was pretty close to saying "screw this shit".

Look at commit 9a630d15f16d, and pray tell me why those kinds of
commit logs are excusable?

That commit message is totally worthless noise. It doesn't explain
what it merges, much less give any explanation of *why* it is a merge.

Merges need explanations too. Tell what the branch you are merging
does, and why you are doing the merge. Yeah, in this case the "branch"
contains a single commit, but that *still* doesn't excuse not telling
what the merge is, and why it exists at all.

Seriously. Do "git log --merges" on current git, and look at the
discrepancy between merge commit messages. That commit 9a630d15f16d is
pure garbage.

It's not the only crappy one, but it really does stand out. There are
other one-liners in there, but even then they tend to have at least
*some* semblance of actual information in them, ie

    Merge branch 'for-v3.16/ti-clk-drv' of
github.com:t-kristo/linux-pm into clk-next

at least shows that there's a topic branch with a reasonable name, and
where it comes from. I'd really prefer it to talk about what it merges
and why, but it's still *much* better than your completely
information-free merge message.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/