linux-kernel - Re: [PATCH] core: fix typo in percpu read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140701204617.GC12459@htj.dyndns.org>
Date:	Tue, 1 Jul 2014 16:46:17 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Filipe Brandenburger <filbranden@...gle.com>
Cc:	Christoph Lameter <cl@...ux-foundation.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Andi Kleen <andi@...stfloor.org>, Zhengyu He <hzy@...gle.com>,
	Greg Thelen <gthelen@...gle.com>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] core: fix typo in percpu read_mostly section

On Tue, Jul 01, 2014 at 12:11:47PM -0700, Filipe Brandenburger wrote:
> From: Zhengyu He <hzy@...gle.com>
> 
> This fixes a typo that named the read_mostly section of percpu as
> readmostly. It works fine with SMP because the linker script specifies
> .data..percpu..readmostly. However, UP kernel builds don't have percpu
> sections defined and the non-percpu version of the section is called
> data..read_mostly, so .data..readmostly will float around and may break
> things unexpectedly.
> 
> Looking at the original change that introduced data..percpu..readmostly
> (commit c957ef2c59e952803766ddc22e89981ab534606f), it looks like this
> was the original intention.
> 
> Tested: Built UP kernel and confirmed the sections got merged.
> 
> - Before the patch:
> $ objdump -h vmlinux.o  | grep '\.data\.\.read.*mostly'
> 38 .data..read_mostly 00004418  0000000000000000  0000000000000000  00431ac0  2**6
> 50 .data..readmostly 00000014  0000000000000000  0000000000000000  00444000  2**3
> 
> - After the patch:
> $ objdump -h vmlinux.o  | grep '\.data\.\.read.*mostly'
> 38 .data..read_mostly 00004438  0000000000000000  0000000000000000  00431ac0  2**6
> 
> Signed-off-by: Zhengyu He <hzy@...gle.com>
> Signed-off-by: Filipe Brandenburger <filbranden@...gle.com>

Applied to percpu/for-3.16-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/