linux-kernel - Re: [PATCH] headers: remove fs.h from poll.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140701220642.GA3150@p183.telecom.by>
Date:	Wed, 2 Jul 2014 01:06:42 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] headers: remove fs.h from poll.h

On Tue, Jul 01, 2014 at 01:43:38PM -0700, Andrew Morton wrote:
> On Tue, 1 Jul 2014 23:01:50 +0300 Alexey Dobriyan <adobriyan@...il.com> wrote:
> 
> > fs.h is new sched.h!
> > 
> > Start removing unnecessary fs.h inclusions.
> > 
> > In the end of the whole series ~2000 useless fs.h inclusions are gone
> > (just need more comple testing).
> > 
> 
> This changelog is rather confusing.
> 
> The patch adds lots *more* fs.h inclusions.  I *think* the intent is to
> remove one nested inclusion in poll.h.  But that contradicts your third
> paragraph.
> 
> Help us out here, OK?

fs.h inclusion is unnecessary because it is only needed
for "struct file" forward declaration.

Those fs.h inclusions are fixing inevitable compilation failures.
There maybe more compilation failures.

What I did to get 2000 number is:
* make allmodconfig
* make
* touch include/linux/fs.h
* make
* [count how many files were rebuilt]

After more header tweaking the number of files that were rebuilt dropped
by ~2000 but code still compiles, which means fs.h inclusions were useless.

This is first patch in series. Same thing we did with sched.h earlier.

	Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/