linux-kernel - RE: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <43e9c89d998b480b869b7ab4d9b4e52c@BL2PR03MB468.namprd03.prod.outlook.com>
Date:	Wed, 2 Jul 2014 08:58:45 +0000
From:	Varun Sethi <Varun.Sethi@...escale.com>
To:	Emilian Medve <Emilian.Medve@...escale.com>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"joro@...tes.org" <joro@...tes.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"alex.williamson@...hat.com" <alex.williamson@...hat.com>
Subject: RE: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.

Thanks Emil.

> -----Original Message-----
> From: Emil Medve [mailto:Emilian.Medve@...escale.com]
> Sent: Wednesday, July 02, 2014 1:16 PM
> To: Sethi Varun-B16395; iommu@...ts.linux-foundation.org;
> joro@...tes.org; linux-kernel@...r.kernel.org; linuxppc-
> dev@...ts.ozlabs.org; alex.williamson@...hat.com
> Subject: Re: [PATCH 1/3] iommu/fsl: Fix PAMU window size check.
> 
> On 06/24/2014 08:57 AM, Varun Sethi wrote:
> > is_power_of_2 requires an unsigned long parameter which would lead to
> > truncation of 64 bit values on 32 bit architectures.
> >
> > __ffs also expects an unsigned long parameter thus won't work for 64
> > bit values on 32 bit architectures.
> >
> > Signed-off-by: Varun Sethi <Varun.Sethi@...escale.com>
> > ---
> >  drivers/iommu/fsl_pamu.c        |    8 ++++----
> >  drivers/iommu/fsl_pamu_domain.c |    2 +-
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> Tested-by: Emil Medve <Emilian.Medve@...escale.com>
> 
> On a P4080 DS (i.e. 32-bit SoC)
> 
> 
> Cheers,