linux-kernel - Re: [PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit and exynos5800-peach-pi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 02 Jul 2014 11:22:42 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Tushar Behera <trblinux@...il.com>,
	Lee Jones <lee.jones@...aro.org>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nel.org>,
	Mike Turquette <mturquette@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Daniel Stone <daniels@...labora.com>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Yadwinder Singh Brar <yadi.brar01@...il.com>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 14/14] ARM: dts: Add max77802 to exynos5420-peach-pit
 and exynos5800-peach-pi

Hello Tushar,

Thanks a lot for your feedback.

On 07/02/2014 11:20 AM, Tushar Behera wrote:
> On 06/26/2014 11:45 PM, Javier Martinez Canillas wrote:
>> Peach pit and pi boards uses a Maxim 77802 power management
>> IC to drive regulators and its Real Time Clock. This patch
>> adds support for this chip.
>> 
>> These are the device nodes and pinctrl configuration that
>> are present on the Peach pit DeviceTree source file in the
>> the Chrome OS kernel 3.8 tree.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
>> Tested-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com>
>> ---
> 
> [ ... ]
> 
>> +
>> +		regulators {
>> +			buck1_reg: BUCK1 {
>> +				regulator-name = "vdd_mif";
>> +				regulator-min-microvolt = <800000>;
>> +				regulator-max-microvolt = <1300000>;
>> +				regulator-always-on;
>> +				regulator-boot-on;
>> +				regulator-ramp-delay = <12500>;
>> +			};
> 
> IMO, adding a blank line between sub-nodes would be better.
> 

Ok

>> +			buck2_reg: BUCK2 {
>> +				regulator-name = "vdd_arm_real";
>> +				regulator-min-microvolt = <800000>;
>> +				regulator-max-microvolt = <1500000>;
>> +				regulator-always-on;
>> +				regulator-boot-on;
>> +				regulator-ramp-delay = <12500>;
>> +			};
> 
> [ ... ]
> 
>> +			vqmmc_sdcard: ldo4_reg: LDO4 {
>> +				regulator-name = "vdd_sd";
>> +				regulator-min-microvolt = <1800000>;
>> +				regulator-max-microvolt = <2800000>;
>> +				regulator-always-on;
>> +
> 
> Blank line, can be removed.
>

Ok

>> +			};
> 
> [ ... ]
>> +			ldo23_reg: LDO23 {
>> +				regulator-name = "ld0_23";
> 
> ldo_23, 'o' in place of '0'.
>

Right, missed that. Thanks for pointing out.

> Similar comments for peach-pi DTS file.
> 

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/