linux-kernel - Re: [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53B3DC52.7040803@collabora.co.uk>
Date:	Wed, 02 Jul 2014 12:17:54 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Mike Turquette <mturquette@...aro.org>,
	Lee Jones <lee.jones@...aro.org>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olof@...om.net>,
	Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
	Daniel Stone <daniels@...labora.com>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Yadwinder Singh Brar <yadi.brar01@...il.com>,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks
 binding

Hello Mike,

On 07/01/2014 07:29 PM, Mike Turquette wrote:
> Quoting Javier Martinez Canillas (2014-06-26 11:15:36)
>> Like most clock drivers, the Maxim 77686 PMIC clock binding
>> follows the convention that the "#clock-cells" property is
>> used to specify the number of cells in a clock provider.
>> 
>> But the binding document is not clear enough that it shall
>> be set to 1 since the PMIC support multiple clocks outputs.
>> 
>> Also, explain that the clocks identifiers are defined in a
>> header file that can be included by Device Tree source with
>> client nodes to avoid using magic numbers.
>> 
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>> Reviewed-by: Doug Anderson <dianders@...omium.org>
> 
> Looks good to me.
> 
> Regards,
> Mike
> 

Thanks a lot, an Acked-by or Reviewed-by tags for this patch and 03/14 will be
great as well so I can carry those on the next version of the series.

Best regards,
Javier

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/