linux-kernel - Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140702111636.GD410@sirena.org.uk>
Date:	Wed, 2 Jul 2014 12:16:36 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Jianqun <xjq@...k-chips.com>
Cc:	Huang Tao <huangtao@...k-chips.com>, heiko@...ech.de,
	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
	grant.likely@...aro.org, robh+dt@...nel.org,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	devicetree@...r.kernel.org, zhangqing@...k-chips.com,
	hj@...k-chips.com, kever.yang@...k-chips.com, zyw@...k-chips.com,
	yzq@...k-chips.com, zhenfu.fang@...k-chips.com, cf@...k-chips.com,
	kfx@...k-chips.com
Subject: Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

On Wed, Jul 02, 2014 at 06:57:46PM +0800, Jianqun wrote:
> Hi Mark:

Don't top post.

> Since regmap_update_bits is int style, I have to error check every time after call it.
> Also I find that the tegra_i2s.c call the function without error checking,

> Could you tell me the right way to handle the regmap_update_bits ?

With memory mapped I/O there's no real point in checking for errors so
if you kno0w your device is memory mapped you can get away with just
ignoring them.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)