linux-kernel - Re: [PATCH] thermal: Bind cooling devices with the correct arguments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Jul 2014 07:54:14 -0400
From:	"edubezval@...il.com" <edubezval@...il.com>
To:	Punit Agrawal <punit.agrawal@....com>
Cc:	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Zhang Rui <rui.zhang@...el.com>
Subject: Re: [PATCH] thermal: Bind cooling devices with the correct arguments

Punit,

On Tue, Jun 3, 2014 at 5:59 AM, Punit Agrawal <punit.agrawal@....com> wrote:
> When binding cooling devices to thermal zones created from the device
> tree the minimum and maximum cooling states are in the wrong order
> leading to failure to bind.
>
> Fix the order of cooling states in the call to
> thermal_zone_bind_cooling_device to fix this.
>
> Cc:Zhang Rui <rui.zhang@...el.com>

Acked-by: Eduardo Valentin <edubezval@...il.com>

Rui, to avoid further delays, can you please pick this one directly?

> Signed-off-by: Punit Agrawal <punit.agrawal@....com>
> ---
> Hi Eduardo,
>
> I am hoping this can be picked up for 3.16 as a bug fix.
>
> Thanks,
> Punit
>
>  drivers/thermal/of-thermal.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
> index 04b1be7..97d312f 100644
> --- a/drivers/thermal/of-thermal.c
> +++ b/drivers/thermal/of-thermal.c
> @@ -156,8 +156,8 @@ static int of_thermal_bind(struct thermal_zone_device *thermal,
>
>                         ret = thermal_zone_bind_cooling_device(thermal,
>                                                 tbp->trip_id, cdev,
> -                                               tbp->min,
> -                                               tbp->max);
> +                                               tbp->max,
> +                                               tbp->min);
>                         if (ret)
>                                 return ret;
>                 }
> --
> 1.7.10.4
>



-- 
Eduardo Bezerra Valentin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/