linux-kernel - Re: [PATCH 49/50] mars: generic pre-patch for mars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Jul 2014 06:27:08 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Thomas Schoebel-Theuer <tst@...oebel-theuer.de>,
	linux-kernel@...r.kernel.org, Thomas Sch?bel-Theuer <tst@...d1.de>
Subject: Re: [PATCH 49/50] mars: generic pre-patch for mars

On Wed, Jul 02, 2014 at 01:24:00AM -0700, Greg KH wrote:
> > I will prepare a new version ASAP.
> > 
> > Is the asmlinkage one of the reasons?
> 
> No.  The wholesale exporting of all 300+ syscall functions for no
> apparent reasoning is the reason.

Using syscalls or syscall-like functionality from kernel code generally
is a bad idea.  Every single use needs a clear rationale in the patch
description.  Which do not seem to exist at all for the series, so in
it's current form it'll go straight to the trash bin anyway.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/