linux-kernel - Re: [PATCH 49/50] mars: generic pre-patch for mars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140702145024.GA19425@infradead.org>
Date:	Wed, 2 Jul 2014 07:50:24 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Thomas Sch?bel-Theuer <tst@...d1.de>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	Thomas Schoebel-Theuer <tst@...oebel-theuer.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 49/50] mars: generic pre-patch for mars

On Wed, Jul 02, 2014 at 04:36:42PM +0200, Thomas Sch?bel-Theuer wrote:
> However, I probably would have to "borrow" large parts of the
> sys_rmdir() implementation from fs/namei.c (the only real difference
> appears to me that the pathname is not in userspace).
> 
> So, what is worse: copying relatively large pieces of code, or using
> sys_rmdir()?

Most likely you shouldn't do either.  A block driver really should not
be removing directories from the filesystem namespace.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/