linux-kernel - Re: [alsa-devel] [PATCH v3] ASoC: tas2552: Support TI TAS2552 Amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53B41F0E.90107@ti.com>
Date:	Wed, 2 Jul 2014 10:02:38 -0500
From:	Dan Murphy <dmurphy@...com>
To:	Daniel Mack <daniel@...que.org>, <linux-sound@...r.kernel.org>
CC:	<devicetree@...r.kernel.org>, <alsa-devel@...a-project.org>,
	<broonie@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH v3] ASoC: tas2552: Support TI TAS2552 Amplifier

Daniel
Thanks for the review

On 07/02/2014 08:47 AM, Daniel Mack wrote:
> Hi Dan,
>
> On 07/02/2014 03:30 PM, Dan Murphy wrote:
>> +	if (np) {
>> +		data->power_gpio = of_get_named_gpio(np, "enable-gpio", 0);
>> +	} else if (pdata) {
>> +		data->power_gpio = pdata->enable_gpio;
>> +	} else {
>> +		dev_err(dev, "Platform or dev tree data not set\n");
>> +		return -ENODEV;
>> +	}
> New code for GPIO handling should use the new gpiod interface.
> See include/linux/gpio/consumer.h, or the sta350 codec driver.

OK good catch.  I will look into it.

Does the gpiod interface handle both pdata as well as dt?

> For that to work, you also need to rename the property to
> 'enable-gpios', even though there's only one.

I am looking for that restriction in the code.  But don't see it.
Will dig some more here.

>
>
> Daniel
>


-- 
------------------
Dan Murphy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/