linux-kernel - Re: [patch 3/4] timerfd: Implement timerfd_ioctl method to restore timerfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53B4382F.9030908@codeaurora.org>
Date:	Wed, 02 Jul 2014 12:49:51 -0400
From:	Christopher Covington <cov@...eaurora.org>
To:	Cyrill Gorcunov <gorcunov@...il.com>
CC:	linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
	Michael Kerrisk <mtk.manpages@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrey Vagin <avagin@...nvz.org>,
	Pavel Emelyanov <xemul@...allels.com>,
	Vladimir Davydov <vdavydov@...allels.com>,
	"Linux ARM kernel mailing list" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [patch 3/4] timerfd: Implement timerfd_ioctl method to restore
 timerfd_ctx::ticks

Hi Cyrill,

On 06/24/2014 06:03 PM, Cyrill Gorcunov wrote:
> The read() of timerfd files allows to fetch the number of timer ticks
> while there is no way to set it back from userspace.
> 
> To restore the timer's state as it was at checkpoint moment we need
> a path to bring @ticks back. Initially I thought about writing ticks
> back via write() interface but it seems such API is somehow obscure.
> 
> Instead implement timerfd_ioctl() method with TFD_IOC_SET_TICKS
> command which allows to adjust @ticks into non-zero value waking
> up the waiters.
> 
> I wrapped code with CONFIG_CHECKPOINT_RESTORE which can be
> dropped off if there users except c/r camp appear.
> 
> v2 (by akpm@):
>  -Use define timerfd_ioctl NULL for non c/r config
> 
> CC: Thomas Gleixner <tglx@...utronix.de>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Andrey Vagin <avagin@...nvz.org>
> CC: Pavel Emelyanov <xemul@...allels.com>
> CC: Vladimir Davydov <vdavydov@...allels.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> ---
> 
> A nit fixed for for non c/r config in timerfd_ioctl declaration
> 
>  fs/timerfd.c            |   37 +++++++++++++++++++++++++++++++++++++
>  include/linux/timerfd.h |    5 +++++
>  2 files changed, 42 insertions(+)
> 
> Index: linux-2.6.git/fs/timerfd.c
> ===================================================================
> --- linux-2.6.git.orig/fs/timerfd.c
> +++ linux-2.6.git/fs/timerfd.c
> @@ -315,12 +315,49 @@ static int timerfd_show(struct seq_file
>  #define timerfd_show NULL
>  #endif
>  
> +#ifdef CONFIG_CHECKPOINT_RESTORE
> +static long timerfd_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
> +{
> +	struct timerfd_ctx *ctx = file->private_data;
> +	int ret = 0;
> +
> +	switch (cmd) {
> +	case TFD_IOC_SET_TICKS: {
> +		u64 ticks;
> +
> +		if (get_user(ticks, (u64 __user *)arg))

64-bit get_user is currently unsupported on ARM, although it appears work is
ongoing [1].

1. https://lkml.org/lkml/2014/6/17/260

Regards,
Christopher

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/