linux-kernel - Re: [PATCH] fix reregistering of serial console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Jul 2014 10:16:44 -0700
From:	Florian Fainelli <florian@...nwrt.org>
To:	Waldemar Brodkorb <wbx@...nadk.org>
Cc:	Linux MIPS Mailing List <linux-mips@...ux-mips.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fix reregistering of serial console

2014-07-02 9:09 GMT-07:00 Waldemar Brodkorb <wbx@...nadk.org>:
> Runtime tested on Mikrotik RB532 board.
> Thanks goes to Geert Uytterhoeven for the explanation of the problem.

The subject should be something like "MIPS: rb532: fix reregistering
of serial console" to be consistent with the other changes.

>
> "I'm afraid this is not gonna help. When the port is unregistered,
> its type will be reset to PORT_UNKNOWN.
> So before registering it again, its type must be set again the actual
> serial driver, cfr. the change to of_serial.c."
>
> Signed-off-by: Waldemar Brodkorb <wbx@...nadk.org>

Reviewed-by: Florian Fainelli <florian@...nwrt.org>

Thanks!

> ---
>  arch/mips/rb532/devices.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/rb532/devices.c b/arch/mips/rb532/devices.c
> index 3af00b2..ba61268 100644
> --- a/arch/mips/rb532/devices.c
> +++ b/arch/mips/rb532/devices.c
> @@ -223,6 +223,7 @@ static struct platform_device rb532_wdt = {
>
>  static struct plat_serial8250_port rb532_uart_res[] = {
>         {
> +               .type           = PORT_16550A,
>                 .membase        = (char *)KSEG1ADDR(REGBASE + UART0BASE),
>                 .irq            = UART0_IRQ,
>                 .regshift       = 2,
> --
> 1.7.10.4
>
>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/