linux-kernel - Re: [PATCH][RFC] USB: zerocopy support for usbfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140702175526.GA21063@kroah.com>
Date:	Wed, 2 Jul 2014 10:55:26 -0700
From:	Greg KH <greg@...ah.com>
To:	Stefan Klug <stefan.klug@...lerweb.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	stern@...land.harvard.edu
Subject: Re: [PATCH][RFC] USB: zerocopy support for usbfs

On Wed, Jul 02, 2014 at 05:53:56PM +0200, Stefan Klug wrote:
> Hi everybody,
> in short: The attached patch adds zerocopy support to the usbfs driver.
> I tested it on x86 and on a globalscale mirabox ARM board. Until now it
> works
> quite nice and I'd love to get some comments and feedback on the patch.

Very nice.

Minor non-technical issues here, your patch is corrupted (linewrapped
and tabs converted to spaces) and can't be applied at all.  Can you fix
your email client and try again?  Look at
Documentation/email_clients.txt for hints on how to do this.

> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -4,6 +4,7 @@
>   *      devio.c  --  User space communication with USB devices.
>   *
>   *      Copyright (C) 1999-2000  Thomas Sailer (sailer@....ee.ethz.ch)
> + *      Copyright (C) 2014  Stefan Klug (stefan.klug@...lerweb.com)

According to legal advice given to me, this isn't needed / true, so can
you drop it?  Or, if you have different legal advice, might I ask for
what the legal justification is that this needs to be added?

>   *      This program is free software; you can redistribute it and/or
> modify
>   *      it under the terms of the GNU General Public License as published
> by
> @@ -30,6 +31,7 @@
>   *    04.01.2000   0.2   Turned into its own filesystem
>   *    30.09.2005   0.3   Fix user-triggerable oops in async URB delivery
>   *                 (CAN-2005-3055)
> + *    07.05.2014   0.4   Added zerocopy support

No need to do this, we use git now and that's where the changelog goes.
We should just delete this "fake changelog" entirely from this file.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/