linux-kernel - Re: question about drivers/spi/spi-au1550.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140702194402.GO410@sirena.org.uk>
Date:	Wed, 2 Jul 2014 20:44:02 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Himangi Saraogi <himangi774@...il.com>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: question about drivers/spi/spi-au1550.c

On Thu, Jul 03, 2014 at 12:31:45AM +0530, Himangi Saraogi wrote:

> I find in the probe function that hw->ioarea is allocated using
> request_mem_region but a release_resource and kfree is called on it instead
> of  a release_mem_region. Is there any special concern behind this. I was
> planning to use devm_ioremap_resource here.

I'd expect this is just a bug you've spotted.  If you could send two
patches, one fixing the bug and the other doing the devm_ conversion,
that'd be ideal but a single patch is also fine.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)