linux-kernel - Re: [Patch] PCI/portdrv: Remove warning about invalid IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140702212538.GC28852@google.com>
Date:	Wed, 2 Jul 2014 15:25:38 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Jiang Liu <jiang.liu@...ux.intel.com>
Cc:	Ryan Desfosses <ryan@...fo.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [Patch] PCI/portdrv: Remove warning about invalid IRQ

On Wed, Jun 18, 2014 at 01:56:21PM +0800, Jiang Liu wrote:
> For hot-added PCIe ports, it always generates a warning message on x86
> platforms when binding to portdrv as:
> 	"device [8086:0e0b] has invalid IRQ; check vendor BIOS".
> 
> It's due to that we check pci_dev->irq before actually allocating IRQ
> for the PCI device:
> 	if (!dev->irq && dev->pin) {
> 		dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; "
> 			 "check vendor BIOS\n", dev->vendor, dev->device);
> 	}
>  	status = pcie_port_device_register(dev);
> 		-->pci_enable_device(dev);
> 			-->pci_enable_device_flags()
> 				-->do_pci_enable_device()
> 					-->pcibios_enable_device()
> 						-->pcibios_enable_irq()
> 
> This warning message isn't generated for PCIe ports present at boot time
> because x86 arch code has called acpi_pci_irq_enable() in pci_acpi_init()
> for each PCI device for safety.
> 
> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>

Applied to pci/misc for v3.17, thanks!

> ---
> Hi Bjorn,
> 	I have rebased it onto v3.16-rc1 and changed the patch title
> according to your suggestion.
> Thanks!
> Gerry
> ___
>  drivers/pci/pcie/portdrv_pci.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index 80887eaa0668..2ccc9b926ea7 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -203,10 +203,6 @@ static int pcie_portdrv_probe(struct pci_dev *dev,
>  	     (pci_pcie_type(dev) != PCI_EXP_TYPE_DOWNSTREAM)))
>  		return -ENODEV;
>  
> -	if (!dev->irq && dev->pin) {
> -		dev_warn(&dev->dev, "device [%04x:%04x] has invalid IRQ; check vendor BIOS\n",
> -			 dev->vendor, dev->device);
> -	}
>  	status = pcie_port_device_register(dev);
>  	if (status)
>  		return status;
> -- 
> 1.7.10.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/