linux-kernel - Re: [PATCH] microblaze: fixes includes in sigcontext.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDOMVh9F7p05wmzaQTpXvAGQzwjuTqJyU__=+e0CzXE152bcw@mail.gmail.com>
Date:	Thu, 3 Jul 2014 18:08:11 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	monstr@...str.eu,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] microblaze: fixes includes in sigcontext.h

You may be right I don't have a compiler that supports microblaze therefore I
would suggest removing this FIXME message.
Cheers Nick

On Thu, Jul 3, 2014 at 5:57 PM, David Rientjes <rientjes@...gle.com> wrote:
> On Thu, 3 Jul 2014, Nicholas Krause wrote:
>
>> diff --git a/arch/microblaze/include/uapi/asm/sigcontext.h b/arch/microblaze/include/uapi/asm/sigcontext.h
>> index 55873c8..1180d9b 100644
>> --- a/arch/microblaze/include/uapi/asm/sigcontext.h
>> +++ b/arch/microblaze/include/uapi/asm/sigcontext.h
>> @@ -9,8 +9,7 @@
>>  #ifndef _ASM_MICROBLAZE_SIGCONTEXT_H
>>  #define _ASM_MICROBLAZE_SIGCONTEXT_H
>>
>> -/* FIXME should be linux/ptrace.h */
>> -#include <asm/ptrace.h>
>> +#include <linux/ptrace.h>
>>
>>  struct sigcontext {
>>       struct pt_regs regs;
>
> Umm, does this even compile?  How does sigcontext.h get the definition of
> struct pt_regs?  Seems like it would be better to just do a forward
> declaration.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/