| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140703082830.GB16590@localhost> Date: Thu, 3 Jul 2014 10:28:30 +0200 From: Johan Hovold <johan@...nel.org> To: Janne Kanniainen <janne.kanniainen@...il.com> Cc: johan@...nel.org, cooloney@...il.com, jkosina@...e.cz, greg@...ah.com, bjorn@...k.no, linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org, linux-usb@...r.kernel.org, linux-input@...r.kernel.org Subject: Re: [PATCH 2/2 v5] HID: leds: move led_mode attribute to led-class devices in MSI GT683R driver On Wed, Jul 02, 2014 at 08:37:59PM +0300, Janne Kanniainen wrote: > Move led_mode attribute from HID device to led-class devices. This will also fix race condition by using attribute-groups. > > Signed-off-by: Janne Kanniainen <janne.kanniainen@...il.com> Looks good now. Thanks! Perhaps you can resend both patches as a series (call both v6) so it's easy to figure which version that is to be applied. I also noticed that your subject line is a bit long (will end up as the commit summary). Using for example HID: gt683r: move mode attribute to led-class devices would make it more concise. Oh, and your commit message lacks line breaks (around 72 cols). You could fix that as well. Thanks again, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists