linux-kernel - Re: [Linuxwacom-devel] [PATCH 06/15] Input - wacom: install LED/OLED sysfs files in the HID device instead of USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140703134547.GA6706@mail.corp.redhat.com>
Date:	Thu, 3 Jul 2014 09:45:47 -0400
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Przemo Firszt <przemo@...szt.eu>
Cc:	linuxwacom-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [Linuxwacom-devel] [PATCH 06/15] Input - wacom: install LED/OLED
 sysfs files in the HID device instead of USB

Hi Przemo,

On Jul 03 2014 or thereabouts, Przemo Firszt wrote:
> 
> Quoting Benjamin Tissoires <benjamin.tissoires@...hat.com>:
> 
> >Removes one more dependency over USB, but requires some changes in
> >the user space to find the sysfs files correctly.
> >
> >This patch breaks the user space. However, the number of program
> >accessing the LEDs is quite limited and we can easily patch them
> >to handle the new HID behavior.
> [..]
> Hi Bejnamin,
> If you get the green light to break the user space we might as well think
> about getting it in line with led/oled over bluetooth (intuos4 wireless) or
> the other way around.

I think it would be easier to fix the bluetooth (current hid) driver. I
think you already implemented the bluetooth handling in gnome 3.12 and
3.13, but having an uniform way of accessing the LEDs/OLEDs would be
nice.

> 
> The biggest user of led/oled functionality is gnome and there are also a few
> small projects that would stop working after that change. I can fix i4oled
> project easily, i4oled-gui is based on gnome handling oleds.

I tried i4oled-gui last week or so, and patching g-s-d was enough. That
was a good idea to rely on gnome internals for your tool :)

> 
> Patching those 2 should be enough to fix gnome:
> https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/wacom/gsd-wacom-led-helper.c
> https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/wacom/gsd-wacom-oled-helper.c

Yes, those two are sufficient enough. I had to make the patches
(http://paste.fedoraproject.org/115318/14043949/) so I could test that nothing
was broken. I'll submit those as soon as the fate of this conversion is
decided.

The current libwacom code also need a fix to handle the hid devices
(bluetooth and this series), and I have to send it for a while now :(

Cheers,
Benjamin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/