| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1404398323-18934-6-git-send-email-tomeu.vizoso@collabora.com>
Date: Thu, 3 Jul 2014 16:38:43 +0200
From: Tomeu Vizoso <tomeu.vizoso@...labora.com>
To: Stephen Warren <swarren@...dotorg.org>,
Thierry Reding <thierry.reding@...il.com>,
Mike Turquette <mturquette@...aro.org>, rabin@....in,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Cc: Javier Martinez Canillas <javier.martinez@...labora.co.uk>,
Tomeu Vizoso <tomeu.vizoso@...labora.com>
Subject: [RFC v2 5/5] clk: Add floor and ceiling constraints to clock rates
Adds a way for clock consumers to set maximum and minimum rates. This can be
used for thermal drivers to set ceiling rates, or by misc. drivers to set
floor rates to assure a minimum performance level.
Signed-off-by: Tomeu Vizoso <tomeu.vizoso@...labora.com>
---
drivers/clk/clk.c | 103 ++++++++++++++++++++++++++++++++++++++++++++
drivers/clk/clk.h | 1 +
drivers/clk/clkdev.c | 7 +--
include/linux/clk-private.h | 1 +
include/linux/clk.h | 18 ++++++++
5 files changed, 124 insertions(+), 6 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index b887c69..3efcd18 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -23,6 +23,19 @@
#include "clk.h"
+enum constraint_type {
+ CONSTRAINT_FLOOR,
+ CONSTRAINT_CEILING,
+};
+
+struct rate_constraint {
+ struct hlist_node node;
+ const char *dev_id;
+ const char *con_id;
+ enum constraint_type type;
+ unsigned long rate;
+};
+
static DEFINE_SPINLOCK(enable_lock);
static DEFINE_MUTEX(prepare_lock);
@@ -1624,6 +1637,7 @@ static void clk_change_rate(struct clk_core *clk)
int clk_provider_set_rate(struct clk_core *clk, unsigned long rate)
{
struct clk_core *top, *fail_clk;
+ struct rate_constraint *constraint;
int ret = 0;
if (!clk)
@@ -1632,6 +1646,17 @@ int clk_provider_set_rate(struct clk_core *clk, unsigned long rate)
/* prevent racing with updates to the clock topology */
clk_prepare_lock();
+ hlist_for_each_entry(constraint, &clk->rate_constraints, node) {
+ switch(constraint->type) {
+ case CONSTRAINT_FLOOR:
+ rate = max(rate, constraint->rate);
+ break;
+ case CONSTRAINT_CEILING:
+ rate = min(rate, constraint->rate);
+ break;
+ }
+ }
+
/* bail early if nothing to do */
if (rate == clk_provider_get_rate(clk))
goto out;
@@ -1695,6 +1720,65 @@ int clk_set_rate(struct clk *clk_user, unsigned long rate)
}
EXPORT_SYMBOL_GPL(clk_set_rate);
+static struct rate_constraint *__ensure_constraint(struct clk *clk_user,
+ enum constraint_type type)
+{
+ struct clk_core *clk = clk_to_clk_core(clk_user);
+ struct rate_constraint *constraint = NULL;
+ bool found = false;
+
+ hlist_for_each_entry(constraint, &clk->rate_constraints, node) {
+ if (constraint->dev_id == clk_user->dev_id &&
+ constraint->con_id == clk_user->con_id &&
+ constraint->type == type)
+ found = true;
+ }
+
+ if (!found) {
+ constraint = kzalloc(sizeof(*constraint), GFP_KERNEL);
+ if (!constraint)
+ return NULL;
+ hlist_add_head(&constraint->node, &clk->rate_constraints);
+ }
+
+ return constraint;
+}
+
+static int __clk_set_constraint(struct clk *clk_user, unsigned long rate,
+ enum constraint_type type)
+{
+ struct clk_core *clk = clk_to_clk_core(clk_user);
+ struct rate_constraint *constraint;
+ int ret;
+
+ clk_prepare_lock();
+
+ constraint = __ensure_constraint(clk_user, type);
+ if (!constraint)
+ return -ENOMEM;
+
+ constraint->rate = rate;
+
+ /* Update the rate so the new constraint is taken into account */
+ ret = clk_provider_set_rate(clk, clk_provider_get_rate(clk));
+
+ clk_prepare_unlock();
+
+ return ret;
+}
+
+int clk_set_floor_rate(struct clk *clk_user, unsigned long rate)
+{
+ return __clk_set_constraint(clk_user, rate, CONSTRAINT_FLOOR);
+}
+EXPORT_SYMBOL_GPL(clk_set_floor_rate);
+
+int clk_set_ceiling_rate(struct clk *clk_user, unsigned long rate)
+{
+ return __clk_set_constraint(clk_user, rate, CONSTRAINT_CEILING);
+}
+EXPORT_SYMBOL_GPL(clk_set_ceiling_rate);
+
struct clk_core *clk_provider_get_parent(struct clk_core *clk)
{
struct clk_core *parent;
@@ -2028,6 +2112,8 @@ int __clk_init(struct device *dev, struct clk_core *clk)
}
}
+ INIT_HLIST_HEAD(&clk->rate_constraints);
+
/*
* optional platform-specific magic
*
@@ -2458,6 +2544,23 @@ int clk_notifier_unregister(struct clk *clk_user, struct notifier_block *nb)
}
EXPORT_SYMBOL_GPL(clk_notifier_unregister);
+void __clk_free_clk(struct clk *clk_user)
+{
+ struct clk_core *clk = clk_to_clk_core(clk_user);
+ struct rate_constraint *constraint;
+ struct hlist_node *tmp;
+
+ hlist_for_each_entry_safe(constraint, tmp, &clk->rate_constraints, node) {
+ if (constraint->dev_id == clk_user->dev_id &&
+ constraint->con_id == clk_user->con_id) {
+ hlist_del(&constraint->node);
+ kfree(constraint);
+ }
+ }
+
+ kfree(clk);
+}
+
#ifdef CONFIG_OF
/**
* struct of_clk_provider - Clock provider registration structure
diff --git a/drivers/clk/clk.h b/drivers/clk/clk.h
index 2f682bf..ea84797 100644
--- a/drivers/clk/clk.h
+++ b/drivers/clk/clk.h
@@ -18,4 +18,5 @@ void of_clk_unlock(void);
#if defined(CONFIG_COMMON_CLK)
struct clk_core *clk_to_clk_core(struct clk *clk);
+void __clk_free_clk(struct clk *clk_user);
#endif
diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c
index 5be6bb1..40f1c66 100644
--- a/drivers/clk/clkdev.c
+++ b/drivers/clk/clkdev.c
@@ -230,16 +230,11 @@ struct clk *clk_get(struct device *dev, const char *con_id)
}
EXPORT_SYMBOL(clk_get);
-static void clk_free_clk(struct clk *clk)
-{
- kfree(clk);
-}
-
void clk_put(struct clk *clk)
{
clk_core_t *core = clk_to_clk_core(clk);
- clk_free_clk(clk);
+ __clk_free_clk(clk);
__clk_put(core);
}
EXPORT_SYMBOL(clk_put);
diff --git a/include/linux/clk-private.h b/include/linux/clk-private.h
index 9657fc8..a8279e1 100644
--- a/include/linux/clk-private.h
+++ b/include/linux/clk-private.h
@@ -48,6 +48,7 @@ struct clk_core {
unsigned long accuracy;
struct hlist_head children;
struct hlist_node child_node;
+ struct hlist_head rate_constraints;
unsigned int notifier_count;
#ifdef CONFIG_DEBUG_FS
struct dentry *dentry;
diff --git a/include/linux/clk.h b/include/linux/clk.h
index 9633459..fbfc8eb 100644
--- a/include/linux/clk.h
+++ b/include/linux/clk.h
@@ -274,6 +274,24 @@ long clk_round_rate(struct clk *clk, unsigned long rate);
int clk_set_rate(struct clk *clk, unsigned long rate);
/**
+ * clk_set_floor_rate - set a minimum clock rate for a clock source
+ * @clk: clock source
+ * @rate: desired minimum clock rate in Hz
+ *
+ * Returns success (0) or negative errno.
+ */
+int clk_set_floor_rate(struct clk *clk, unsigned long rate);
+
+/**
+ * clk_set_ceiling_rate - set a maximum clock rate for a clock source
+ * @clk: clock source
+ * @rate: desired maximum clock rate in Hz
+ *
+ * Returns success (0) or negative errno.
+ */
+int clk_set_ceiling_rate(struct clk *clk, unsigned long rate);
+
+/**
* clk_set_parent - set the parent clock source for this clock
* @clk: clock source
* @parent: parent clock source
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists