linux-kernel - Re: [PATCH v4] ASoC: tas2552: Support TI TAS2552 Amplifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140703145250.GO5814@saruman.home>
Date:	Thu, 3 Jul 2014 09:52:50 -0500
From:	Felipe Balbi <balbi@...com>
To:	Dan Murphy <dmurphy@...com>
CC:	<linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<alsa-devel@...a-project.org>, <broonie@...nel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v4] ASoC: tas2552: Support TI TAS2552 Amplifier

Hi,

On Thu, Jul 03, 2014 at 09:39:53AM -0500, Dan Murphy wrote:
> +static int tas2552_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
> +{
> +	u8 serial_format;
> +	struct snd_soc_codec *codec = dai->codec;
> +
> +	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> +	case SND_SOC_DAIFMT_CBS_CFS:
> +		serial_format = 0x00;
> +		break;
> +	case SND_SOC_DAIFMT_CBS_CFM:
> +		serial_format = TAS2552_WORD_CLK_MASK;
> +		break;
> +	case SND_SOC_DAIFMT_CBM_CFS:
> +		serial_format = TAS2552_BIT_CLK_MASK;
> +		break;
> +	case SND_SOC_DAIFMT_CBM_CFM:
> +		serial_format = (TAS2552_BIT_CLK_MASK | TAS2552_WORD_CLK_MASK);
> +		break;
> +	default:
> +		return -EINVAL;
> +	}
> +
> +	pm_runtime_get_sync(codec->dev);
> +
> +	snd_soc_update_bits(codec, TAS2552_SER_CTRL_1,
> +			    (TAS2552_BIT_CLK_MASK | TAS2552_WORD_CLK_MASK),
> +			    serial_format);
> +
> +	pm_runtime_put(codec->dev);

I have a feeling it's better to just put at the end of the function.
Remember your pm_runtime_put() will issue i2c transfers which can take a
looooooong time ;-)

other than that, looks ok to me:

Reviewed-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)