linux-kernel - Re: [PATCH 1/3] regmap: cache: regcache_hw_init() should use regmap_bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140703145517.GE410@sirena.org.uk>
Date:	Thu, 3 Jul 2014 15:55:17 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Doug Anderson <dianders@...omium.org>
Cc:	Lee Jones <lee.jones@...aro.org>, Wolfram Sang <wsa@...-dreams.de>,
	Vincent Palatin <vpalatin@...omium.org>,
	Bill Richardson <wfrichar@...omium.org>,
	Randall Spangler <rspangler@...omium.org>, sjg@...omium.org,
	afaerber@...e.de, stephan@...khronix.com, olof@...om.net,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] regmap: cache: regcache_hw_init() should use
 regmap_bulk_read()

On Fri, Jun 27, 2014 at 12:56:11PM -0700, Doug Anderson wrote:

> We really should be using regmap_bulk_read() in regcache_hw_init().
> The regmap_bulk_read() will translate into regmap_raw_read() when
> appropriate.  Doing this fixes problems where regmap_smbus() will
> crash because they don't implement .read and .write.

Not quite - _bulk_read() does do byte swapping so...

> -		ret = regmap_raw_read(map, 0, tmp_buf,
> +		ret = regmap_bulk_read(map, 0, tmp_buf,
>  				      map->num_reg_defaults_raw);
>  		map->cache_bypass = cache_bypass;
>  		if (ret < 0) {

...a direct replacement shouldn't quite work.  We need an actual
fallback to word at a time operation I think.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)