linux-kernel - Re: [PATCH] Lattice ECP3 FPGA: Correct endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53B57DDE.90603@denx.de>
Date:	Thu, 03 Jul 2014 17:59:26 +0200
From:	Stefan Roese <sr@...x.de>
To:	Jean-Michel Hautbois <jean-michel.hautbois@...alys.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Lattice ECP3 FPGA: Correct endianness

On 03.07.2014 17:54, Jean-Michel Hautbois wrote:
> This patch corrects three big/little endian issues. Tested on i.MX6.
> 
> From: Jean-Michel Hautbois <jean-michel.hautbois@...alys.com>
> Date: Thu, 3 Jul 2014 17:49:47 +0200
> Subject: [PATCH] Endianness corrections
> 
> ---
>   drivers/misc/lattice-ecp3-config.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/misc/lattice-ecp3-config.c
> b/drivers/misc/lattice-ecp3-config.c
> index bb26f08..23d5c01 100644
> --- a/drivers/misc/lattice-ecp3-config.c
> +++ b/drivers/misc/lattice-ecp3-config.c
> @@ -93,7 +93,7 @@ static void firmware_load(const struct firmware *fw,
> void *context)
>       txbuf[0] = FPGA_CMD_READ_ID;
>       ret = spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len);
>       dev_dbg(&spi->dev, "FPGA JTAG ID=%08x\n", *(u32 *)&rxbuf[4]);
> -    jedec_id = *(u32 *)&rxbuf[4];
> +    jedec_id = be32_to_cpu(*(u32 *)&rxbuf[4]);
> 
>       for (i = 0; i < ARRAY_SIZE(ecp3_dev); i++) {
>           if (jedec_id == ecp3_dev[i].jedec_id)
> @@ -142,7 +142,7 @@ static void firmware_load(const struct firmware
> *fw, void *context)
>       for (i = 0; i < FPGA_CLEAR_LOOP_COUNT; i++) {
>           txbuf[0] = FPGA_CMD_READ_STATUS;
>           ret = spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len);
> -        status = *(u32 *)&rxbuf[4];
> +        status = be32_to_cpu(*(u32 *)&rxbuf[4]);
>           if (status == FPGA_STATUS_CLEARED)
>               break;
> 
> @@ -165,8 +165,8 @@ static void firmware_load(const struct firmware
> *fw, void *context)
> 
>       txbuf[0] = FPGA_CMD_READ_STATUS;
>       ret = spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len);
> -    dev_dbg(&spi->dev, "FPGA Status=%08x\n", *(u32 *)&rxbuf[4]);
> -    status = *(u32 *)&rxbuf[4];
> +    dev_dbg(&spi->dev, "FPGA Status=%08x\n", be32_to_cpu(*(u32 *)&rxbuf[4]));
> +    status = be32_to_cpu(*(u32 *)&rxbuf[4]);

I know you didn't introduce this, but this re-ordering does look better:

+    status = be32_to_cpu(*(u32 *)&rxbuf[4]);
+    dev_dbg(&spi->dev, "FPGA Status=%08x\n", status);

Other than that:

Acked-by: Stefan Roese <sr@...x.de>

Thanks,
Stefan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/