linux-kernel - Re: [RFC PATCH v2 05/11] MIPS: Alchemy: pci: use clk framework to enable PCI clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOLZvyFit=cuXHjtx=v2oOBAdj9yj1nwODzBQ+3EP7MpongZoA@mail.gmail.com>
Date:	Thu, 3 Jul 2014 19:19:52 +0200
From:	Manuel Lauss <manuel.lauss@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Linux-MIPS <linux-mips@...ux-mips.org>,
	Mike Turquette <mturquette@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2 05/11] MIPS: Alchemy: pci: use clk framework to
 enable PCI clock

Hi Sergei,

On Thu, Jul 3, 2014 at 3:50 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
>> --- a/arch/mips/pci/pci-alchemy.c
>> +++ b/arch/mips/pci/pci-alchemy.c
>> @@ -394,11 +396,24 @@ static int alchemy_pci_probe(struct platform_device
>> *pdev)

>> +       ret = clk_prepare_enable(c);
>> +       if (ret) {
>> +               dev_err(&pdev->dev, "cannot enable PCI clock\n");
>> +               clk_put(c);
>> +               goto out2;
>
>
>    Isn't it simpler to add one more label before clk_put() at end of
> function?

Yes, I have changed it locally.


Thank you!
       Manuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/