linux-kernel - Re: [PATCH 1/1] fs/ecryptfs/messaging.c: remove null test before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140703213257.GA5089@boyd>
Date:	Thu, 3 Jul 2014 16:32:57 -0500
From:	Tyler Hicks <tyhicks@...onical.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, ecryptfs@...r.kernel.org
Subject: Re: [PATCH 1/1] fs/ecryptfs/messaging.c: remove null test before
 kfree

On 2014-06-16 20:06:12, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
> 
> Cc: Tyler Hicks <tyhicks@...onical.com>
> Cc: ecryptfs@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---

Hi Fabian - Sorry for being slow to respond. This patch looks good. I'll
push it to my next branch.

Tyler

>  fs/ecryptfs/messaging.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ecryptfs/messaging.c b/fs/ecryptfs/messaging.c
> index e57380e..286f10b 100644
> --- a/fs/ecryptfs/messaging.c
> +++ b/fs/ecryptfs/messaging.c
> @@ -434,8 +434,7 @@ void ecryptfs_release_messaging(void)
>  		mutex_lock(&ecryptfs_msg_ctx_lists_mux);
>  		for (i = 0; i < ecryptfs_message_buf_len; i++) {
>  			mutex_lock(&ecryptfs_msg_ctx_arr[i].mux);
> -			if (ecryptfs_msg_ctx_arr[i].msg)
> -				kfree(ecryptfs_msg_ctx_arr[i].msg);
> +			kfree(ecryptfs_msg_ctx_arr[i].msg);
>  			mutex_unlock(&ecryptfs_msg_ctx_arr[i].mux);
>  		}
>  		kfree(ecryptfs_msg_ctx_arr);
> -- 
> 1.8.4.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe ecryptfs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)