linux-kernel - [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1404363116-10538-1-git-send-email-peter.ujfalusi@ti.com>
Date:	Thu, 3 Jul 2014 07:51:51 +0300
From:	Peter Ujfalusi <peter.ujfalusi@...com>
To:	<vinod.koul@...el.com>, <dan.j.williams@...el.com>,
	<lars@...afoo.de>, <tiwai@...e.de>,
	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>, <joelf@...com>,
	<nsekhar@...com>
CC:	<linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>,
	<dmaengine@...r.kernel.org>
Subject: [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support

Hi,

Changes since v2 (in patch 3):
- Replace BIT(bits / 8) with (1 << (bits / 8)) as pointed out by Takashi
- Use switch (addr_widths) to filter non valid physical widths, like -EINVAL or
  widths not dividable by 8.
  The same check could be done with:
  if (bits > 0 && bits <=64 && !(bits % 8) && (addr_widths & (1 << (bits / 8))))
  But I think the switch() implementation is more readable.

Changes since v1:
- the hw.formats mask preparation moved to dmaengine_pcm_set_runtime_hwparams()
- we prepare the mask for all supported sample formats based on the physical
  width of the sample and on the slave_caps information.

I have noticed while switching the daVinci audio to dmaengine_pcm that the _3LE
and _3BE support is not working correctly via dmaengine_pcm:
In case of _3LE/_3BE formats the samples are stored in 3 consecutive bytes
without padding it to 4 bytes. This means that the DMA needs to be able to
support 3 bytes word length in order to read/write the samples from memory
correctly. Originally the code treated 24 bits physical length samples as
they were 32 bits which leads to corruption when playing or recording audio.

To fix the support for 3 bytes physical samples the dma driver also need to have
support for such data arrangement. eDMA does have support for it in HW and the
legacy davinci-pcm platform driver w/o dmaengine was able to support such
formats.

First step is to add DMA_SLAVE_BUSWIDTH_3_BYTES to dma_slave_buswidth for
engines and users to select 3 bytes as bus width.

Followed by:
In dmaengine_pcm_set_runtime_hwparams() we should check the slave_caps of the
dma if it supports the give sample physical width of the sample. Based on this
information we initialize the hw.formats: masking out all non supported formats
based on the physical width.
In case the dma driver does not implement the slave_caps the default assumption
is that it supports 1, 2 and 4 bytes widths.

Regards,
Peter
---
Peter Ujfalusi (5):
  dma: Support for 3 bytes word size
  ALSA: pcm_dmaengine: Use the available wrapper to get physical width
  ASoC: generic-dmaengine-pcm: Prepare formats mask for valid physical
    sample sizes
  ALSA: pcm_dmaengine: Correct support for 24bits physical sample widths
  dma: edma: Declare DMA_SLAVE_BUSWIDTH_3_BYTES as supported buswidth

 drivers/dma/edma.c                    |  1 +
 include/linux/dmaengine.h             |  1 +
 sound/core/pcm_dmaengine.c            |  4 +++-
 sound/soc/soc-generic-dmaengine-pcm.c | 37 ++++++++++++++++++++++++++++++++++-
 4 files changed, 41 insertions(+), 2 deletions(-)

-- 
2.0.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/