linux-kernel - Re: [PATCH v5 00/11] Add DRM for stih4xx platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 Jul 2014 22:58:26 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Rob Clark <robdclark@...il.com>
Cc:	Benjamin Gaignard <benjamin.gaignard@...aro.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Thierry Reding <thierry.reding@...il.com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>
Subject: Re: [PATCH v5 00/11] Add DRM for stih4xx platforms

On Thu, Jul 03, 2014 at 10:52:00PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 03, 2014 at 05:31:21PM -0400, Rob Clark wrote:
> > >From a brief look, it looks like my comments have been addressed, so I
> > think this is starting to shape up..
> > 
> > Laurent/Thierry/Russell, I don't suppose any of you are likely to have
> > time before 3.17 merge window to give sti one last once-over to see
> > what I missed ;-)
> 
> As this appears to be using the component helpers, it would be good for
> the author to be pre-warned about the change to the API.  I'm going to
> be doing this as a two step thing.

More on this... just found it in the series.

It looks fine, and I expect that the update would be trivial:

- the body of sti_drm_add_components() moves into sti_drm_master_probe()
  and sti_drm_add_components() is removed.
- component_master_add_child() is updated to call component_match_add()
- component_master_add() is updated to call component_master_add_with_match()
  instead.

So I don't think there's any problem here.

-- 
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving, and getting towards what was expected from it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/