linux-kernel - Re: [PATCH] drivers/gpio/gpio-sch311x: check return value of gpiochip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53B64DA4.3070400@gmail.com>
Date:	Fri, 04 Jul 2014 12:15:56 +0530
From:	Varka Bhadram <varkabhadram@...il.com>
To:	Varka Bhadram <varkabhadram@...il.com>, linux-gpio@...r.kernel.org
CC:	linus.walleij@...aro.org, gnurou@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/gpio/gpio-sch311x: check return value of gpiochip_remove()

Hi,

Please drop this patch which generating an another warning.

I will send v2 for this.

Thanks.

On 07/04/2014 12:07 PM, Varka Bhadram wrote:
> This patch eliminates the following warning
>
> drivers/gpio/gpio-sch311x.c: In function ‘sch311x_gpio_probe’:
> drivers/gpio/gpio-sch311x.c:286:18: warning: ignoring return value of ‘gpiochip_remove’, declared with attribute warn_unused_result
>
> Signed-off-by: Varka Bhadram <varkab@...c.in>
> ---
>   drivers/gpio/gpio-sch311x.c |    8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sch311x.c b/drivers/gpio/gpio-sch311x.c
> index f942b80..8a4ab8f 100644
> --- a/drivers/gpio/gpio-sch311x.c
> +++ b/drivers/gpio/gpio-sch311x.c
> @@ -232,7 +232,7 @@ static int sch311x_gpio_probe(struct platform_device *pdev)
>   	struct sch311x_pdev_data *pdata = pdev->dev.platform_data;
>   	struct sch311x_gpio_priv *priv;
>   	struct sch311x_gpio_block *block;
> -	int err, i;
> +	int err, i, ret;
>   
>   	/* we can register all GPIO data registers at once */
>   	if (!request_region(pdata->runtime_reg + GP1, 6, DRV_NAME)) {
> @@ -283,7 +283,11 @@ exit_err:
>   	release_region(pdata->runtime_reg + GP1, 6);
>   	/* release already registered chips */
>   	for (--i; i >= 0; i--)
> -		gpiochip_remove(&priv->blocks[i].chip);
> +		ret = gpiochip_remove(&priv->blocks[i].chip);
> +
> +		WARN(ret, "%s(): gpiochip_remove() failed, ret=%d\n",
> +		     __func__, ret);
> +
>   	return err;
>   }
>   


-- 
Cheers,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/