linux-kernel - Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140704080702.GA31812@leverpostej>
Date:	Fri, 4 Jul 2014 09:07:02 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Tomasz Figa <t.figa@...sung.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree
 bindings document

On Thu, Jul 03, 2014 at 12:44:34PM +0100, Krzysztof Kozlowski wrote:
> On czw, 2014-07-03 at 12:32 +0100, Mark Rutland wrote:
> > Hi,
> > 
> > On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wrote:
> > > Add document describing device tree bindings for MAX14577 MFD
> > > drivers: MFD core, extcon, regulator and charger.
> > > 
> > > Both MAX14577 and MAX77836 chipsets are documented.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> > > Cc: Kyungmin Park <kyungmin.park@...sung.com>
> > > Cc: Tomasz Figa <t.figa@...sung.com>
> > > Cc: devicetree@...r.kernel.org
> > > Cc: Rob Herring <robh+dt@...nel.org>
> > > Cc: Pawel Moll <pawel.moll@....com>
> > > Cc: Mark Rutland <mark.rutland@....com>
> > > Cc: Ian Campbell <ijc+devicetree@...lion.org.uk>
> > > Cc: Kumar Gala <galak@...eaurora.org>
> > > Reviewed-by: Tomasz Figa <t.figa@...sung.com>
> > > ---
> > >  Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++
> > >  1 file changed, 152 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt
> > > new file mode 100644
> > > index 000000000000..b235250a7b41
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/max14577.txt
> > > @@ -0,0 +1,152 @@
> > > +Maxim MAX14577/77836 Multi-Function Device
> > > +
> > > +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+
> > > +Battery Charger and SFOUT LDO output for powering USB devices. It is
> > > +interfaced to host controller using I2C.
> > > +
> > > +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge.
> > > +
> > > +
> > > +Required properties:
> > > +- compatible : Must be "maxim,max14577" or "maxim,max77836".
> > > +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836)
> > > +- interrupts : IRQ line for the chip.
> > > +- interrupt-parent :  The parent interrupt controller.
> > > +
> > > +
> > > +Required nodes:
> > > + - charger :
> > > +	Node for configuring the charger driver.
> > > +	Required properties:
> > > +		- compatible : "maxim,max14577-charger"
> > > +			or "maxim,max77836-charger"
> > > +		- maxim,fast-charge-timer : Timer in hours to trigger the
> > > +			INT3/MBCCHGERR interrupt; Valid values:
> > > +			- 5, 6 or 7 (hours),
> > > +			- 0 to disable.
> > 
> > I'm not sure I follow what this is any why it should be in the DT.
> > 
> > Could you explain what this is used for?
> 
> Hi,
> 
> These are settings for max14577 battery charger. Actually this
> particular setting does not look like board-specific but other (like
> battery voltage) do.
> 
> The timer above is used by device to stop charging and to trigger
> interrupt.

Ok. What I don't get is why this should be in the DT, it sounds like a
configuration option that would better be set at run time.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/