linux-kernel - Re: [PATCH v2 1/3] readq/writeq: Add explicit lo_hi_[read|write]_q and hi_lo_[read|write]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140704140755.GA3340@pd.tnic>
Date:	Fri, 4 Jul 2014 16:07:55 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Jason Baron <jbaron@...mai.com>
Cc:	m.chehab@...sung.com, tony.luck@...el.com, hpa@...or.com,
	mingo@...nel.org, dougthompson@...ssion.com,
	mitake@....info.waseda.ac.jp, aris@...hat.com,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] readq/writeq: Add explicit lo_hi_[read|write]_q
 and hi_lo_[read|write]_q

On Thu, Jun 26, 2014 at 09:58:28PM +0000, Jason Baron wrote:
> Even on x86-64, I've found the need to break up a readq() into 2 readl()
> calls. According to the Intel datasheet for the E3-1200 processor:
> 
> "
> Software must not access B0/D0/F0 32-bit memory-mapped registers with
> requests that cross a DW boundary.
> "
> 
> (http://www.intel.com/content/www/us/en/processors/xeon/xeon-e3-1200-family-vol-2-datasheet.html p. 16)
> 
> I can confirm this is true via several hard machine lockups.
> 
> Thus, add explicit hi_lo_[readq|write]_q and lo_hi_[read|write]_q so that these
> uses are spelled out.
> 
> Signed-off-by: Jason Baron <jbaron@...mai.com>

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/