linux-kernel - Re: [PATCH] Lattice ECP3 FPGA: Correct endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL8zT=hVhtZ7SPguhpYY22hTLaao4ZpwG3HWV3F3SR5mO4mw-w@mail.gmail.com>
Date:	Fri, 4 Jul 2014 17:16:39 +0200
From:	Jean-Michel Hautbois <jean-michel.hautbois@...alys.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Stefan Roese <sr@...x.de>
Subject: Re: [PATCH] Lattice ECP3 FPGA: Correct endianness

2014-07-04 16:58 GMT+02:00 Geert Uytterhoeven <geert@...ux-m68k.org>:
> On Thu, Jul 3, 2014 at 5:54 PM, Jean-Michel Hautbois
> <jean-michel.hautbois@...alys.com> wrote:
>> --- a/drivers/misc/lattice-ecp3-config.c
>> +++ b/drivers/misc/lattice-ecp3-config.c
>> @@ -93,7 +93,7 @@ static void firmware_load(const struct firmware *fw,
>> void *context)
>>      txbuf[0] = FPGA_CMD_READ_ID;
>>      ret = spi_write_then_read(spi, txbuf, 8, rxbuf, rx_len);
>>      dev_dbg(&spi->dev, "FPGA JTAG ID=%08x\n", *(u32 *)&rxbuf[4]);
>> -    jedec_id = *(u32 *)&rxbuf[4];
>> +    jedec_id = be32_to_cpu(*(u32 *)&rxbuf[4]);
>
> What about "jedec_id = get_unaligned_be32(&rxbuf[4]);" instead?

Eh I didn't know such a function existed ! :)

JM
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/