linux-kernel - Re: [PATCH] m68k: Remove FIXME comment in file sun3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWJ=6FDzZg0p-_9eFaJ7sKrmmsJBy0sM5tsrGLFL0PgVg@mail.gmail.com>
Date:	Fri, 4 Jul 2014 18:17:38 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Nick Krause <xerofoify@...il.com>
Cc:	Finn Thain <fthain@...egraphics.com.au>,
	Sam Creasey <sammy@...my.net>,
	linux-m68k <linux-m68k@...ts.linux-m68k.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] m68k: Remove FIXME comment in file sun3_pgalloc.h

On Fri, Jul 4, 2014 at 6:10 PM, Nick Krause <xerofoify@...il.com> wrote:
> Very well then seems I should resend this patch removing the define
> line as it seems to have no use
> in this file.

Indeed. Thanks in advance!
FYI, the last user of _KERNPG_TABLE was removed in 2.5.18.

> Cheers Nick
>
> On Fri, Jul 4, 2014 at 2:19 AM, Finn Thain <fthain@...egraphics.com.au> wrote:
>>
>> On Fri, 4 Jul 2014, Nick Krause wrote:
>>
>>> What are these two lines for them another compile issue?
>>
>> I don't see why those two lines are important.
>>
>>> >> -/* FIXME - when we get this compiling */
>>> >>  /* erm, now that it's compiling, what do we do with it? */
>>> >>  #define _KERNPG_TABLE 0
>>
>> Presumably it is the third line that the "FIXME" refers to.
>>
>> I didn't write this code, but obviously it isn't supposed to be read as
>>
>> /* FIXME - this comment needs to be deleted */

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/