linux-kernel - Re: [PATCH 2/3] clocksource: add device-tree support for PXA timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874mywoqjt.fsf@free.fr>
Date:	Fri, 04 Jul 2014 21:46:30 +0200
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:	Haojian Zhuang <haojian.zhuang@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] clocksource: add device-tree support for PXA timer

Daniel Lezcano <daniel.lezcano@...aro.org> writes:

>> Good question.
>>
>> Maybe not, I followed the same rationale as in orion-timer, which is :
>>   - as this timer is the only possible timer for PXA boards, and because without
>>   it the kernel boot will stall (scheduling will be blocked), it's better to
>>   panic early that to remain stalled.
>
> There isn't the arm global timer ?
Nope, it's for Cortex-A9 AFAIK, and my poor platform is an old ARMv5 SoC.

>
>> Isn't this a good approach ?
>
> I suppose we can live with that. IMO, the right fix would be in clksrc-of to
> pr_crit a message when an initialization fails. But that means to change all the
> init functions for all drivers which is out of the scope of this patchset.
OK, you convinced me. I'll trade the panic() for a pr_crit(). Good idea, maybe
it will trigger a quest of a white knight for the other drivers :)

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/