linux-kernel - Re: [PATCH] kbuild: Do not run modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 05 Jul 2014 00:15:28 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Andy Lutomirski <luto@...capital.net>
CC:	"H. Peter Anvin" <hpa@...or.com>, X86 ML <x86@...nel.org>,
	"linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kbuild: Do not run modules_install and install in paralel

Dne 13.6.2014 19:29, Andy Lutomirski napsal(a):
> On Fri, Jun 13, 2014 at 2:45 AM, Michal Marek <mmarek@...e.cz> wrote:
>> Dne 13.6.2014 11:39, Michal Marek napsal(a):
>>> Based on a x86-only patch by Andy Lutomirski <luto@...capital.net>
>>>
>>> With modular kernels, 'make install' is going to need the installed
>>> modules at some point to generate the initramfs.
>>>
>>> Signed-off-by: Michal Marek <mmarek@...e.cz>
>>> ---
>>>  Makefile | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index 7680d7c..7e5e483 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),)
>>>                  endif
>>>          endif
>>>  endif
>>> +# install and module_install need also be processed one by one
>>> +ifneq ($(filter install,$(MAKECMDGOALS)),)
>>> +        ifneq ($(filter modules_install,$(MAKECMDGOALS)),)
>>> +             mixed-targets := 1
>>> +        endif
>>> +endif
>>
>> Note that this version does not enforce the ordering, it just avoids the
>> interleaved execution. It can be added if desired.
> 
> Hmm.  This will fix 'make modules_install install' but will not fix
> 'make install modules_install'.  I don't know how many people would
> type the latter.

Resuming a thread from last month -- As I said, it does not enforce the
ordering. So it's not as bullet-proof as your patch, but it works on all
architectures. I'm thinking about adding the patch to kbuild.git for
3.17. But if you want to fix the ordering as well, feel free to change
the __build_one_by_one rule to do this.

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/