| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Jul 2014 03:48:03 -0700 From: tip-bot for Jason Low <tipbot@...or.com> To: linux-tip-commits@...r.kernel.org Cc: linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org, torvalds@...ux-foundation.org, peterz@...radead.org, jason.low2@...com, tglx@...utronix.de, davidlohr@...com Subject: [tip:locking/core] locking/mutexes: Optimize mutex trylock slowpath Commit-ID: 72d5305dcb3637913c2c37e847a4de9028e49244 Gitweb: http://git.kernel.org/tip/72d5305dcb3637913c2c37e847a4de9028e49244 Author: Jason Low <jason.low2@...com> AuthorDate: Wed, 11 Jun 2014 11:37:23 -0700 Committer: Ingo Molnar <mingo@...nel.org> CommitDate: Sat, 5 Jul 2014 11:25:42 +0200 locking/mutexes: Optimize mutex trylock slowpath The mutex_trylock() function calls into __mutex_trylock_fastpath() when trying to obtain the mutex. On 32 bit x86, in the !__HAVE_ARCH_CMPXCHG case, __mutex_trylock_fastpath() calls directly into __mutex_trylock_slowpath() regardless of whether or not the mutex is locked. In __mutex_trylock_slowpath(), we then acquire the wait_lock spinlock, xchg() lock->count with -1, then set lock->count back to 0 if there are no waiters, and return true if the prev lock count was 1. However, if the mutex is already locked, then there isn't much point in attempting all of the above expensive operations. In this patch, we only attempt the above trylock operations if the mutex is unlocked. Signed-off-by: Jason Low <jason.low2@...com> Reviewed-by: Davidlohr Bueso <davidlohr@...com> Signed-off-by: Peter Zijlstra <peterz@...radead.org> Cc: akpm@...ux-foundation.org Cc: tim.c.chen@...ux.intel.com Cc: paulmck@...ux.vnet.ibm.com Cc: rostedt@...dmis.org Cc: Waiman.Long@...com Cc: scott.norton@...com Cc: aswin@...com Cc: Linus Torvalds <torvalds@...ux-foundation.org> Link: http://lkml.kernel.org/r/1402511843-4721-5-git-send-email-jason.low2@hp.com Signed-off-by: Ingo Molnar <mingo@...nel.org> --- kernel/locking/mutex.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/locking/mutex.c b/kernel/locking/mutex.c index e4d997b..11b103d 100644 --- a/kernel/locking/mutex.c +++ b/kernel/locking/mutex.c @@ -820,6 +820,10 @@ static inline int __mutex_trylock_slowpath(atomic_t *lock_count) unsigned long flags; int prev; + /* No need to trylock if the mutex is locked. */ + if (mutex_is_locked(lock)) + return 0; + spin_lock_mutex(&lock->wait_lock, flags); prev = atomic_xchg(&lock->count, -1); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists