linux-kernel - Re: [PATCH] staging: nvec: remove unneccessary 'else' after 'return'statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140705134903.89ec088a6b90e48be9c36f89@gmx.de>
Date:	Sat, 5 Jul 2014 13:49:03 +0200
From:	Marc Dietrich <marvin24@....de>
To:	Julian Andres Klode <jak@...-linux.org>
Cc:	Pawel Lebioda <pawel.lebioda89@...il.com>,
	Marc Dietrich <marvin24@....de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	ac100@...ts.launchpad.net, linux-tegra@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: nvec: remove unneccessary 'else' after
 'return'statement

On Fri, 4 Jul 2014 22:59:41 +0200
Julian Andres Klode <jak@...-linux.org> wrote:

> On Fri, Jul 04, 2014 at 09:57:50PM +0200, Pawel Lebioda wrote:
> > Hi,
> >
> > This patch fixes the following warning reported by checkpatch.pl:
> > 
> > WARNING: else is not generally useful after a break or return
> > #235: FILE: drivers/staging/nvec/nvec.c:235:
> > 
> > Regards
> > Pawel Lebioda
> > 
> > Signed-off-by: Pawel Lebioda <pawel.lebioda89@...il.com>
> >  drivers/staging/nvec/nvec.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Hi Pawel,
> 
> Please format your patches correctly. There should be no
> "Hi", no "Regards", etc. After the signed off should be a
> dashed line.
> 
> Use git format-patch to format patches and you can send
> them using git-send-email.

yes, this way you reduce some apply-burdon from Greg. Ideally,
you would combine all patches (one patch per checkpatch warning)
in a common thread like this:

git-format-patch --cover-letter --thread -s <first commit of your
patches>

This way you could add some comments (if any) to the cover letter
and just keep the plain checkpatch message in the other patches. This
has also the advantage that the maintainers only have to ack the "cover
letter".

Marc
 
-- 
Marc Dietrich <marvin24@....de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/