lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Jul 2014 14:14:24 +0200 From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> To: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Tomi Valkeinen <tomi.valkeinen@...com> Cc: Rickard Strandqvist <rickard.strandqvist@...ymobile.com>, Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>, Geert Uytterhoeven <geert@...ux-m68k.org>, Jingoo Han <jg1.han@...sung.com>, Daniel Vetter <daniel.vetter@...ll.ch>, Joe Perches <joe@...ches.com>, Michael Schmitz <schmitzmic@...il.com>, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] video: fbdev: atafb.c: Cleaning up variable that is never used From: Rickard Strandqvist <rickard.strandqvist@...ymobile.com> Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> --- drivers/video/fbdev/atafb.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/video/fbdev/atafb.c b/drivers/video/fbdev/atafb.c index 4953b65..1bedbf35 100644 --- a/drivers/video/fbdev/atafb.c +++ b/drivers/video/fbdev/atafb.c @@ -2546,7 +2546,6 @@ static void atafb_copyarea(struct fb_info *info, const struct fb_copyarea *area) struct atafb_par *par = (struct atafb_par *)info->par; int x2, y2; u32 dx, dy, sx, sy, width, height; - int rev_copy = 0; #ifdef ATAFB_FALCON if (info->var.bits_per_pixel == 16) { @@ -2580,7 +2579,6 @@ static void atafb_copyarea(struct fb_info *info, const struct fb_copyarea *area) if (dy > sy || (dy == sy && dx > sx)) { dy += height; sy += height; - rev_copy = 1; } if (info->var.bits_per_pixel == 1) @@ -2599,8 +2597,6 @@ static void atafb_imageblit(struct fb_info *info, const struct fb_image *image) { struct atafb_par *par = (struct atafb_par *)info->par; int x2, y2; - unsigned long *dst; - int dst_idx; const char *src; u32 dx, dy, width, height, pitch; @@ -2627,10 +2623,6 @@ static void atafb_imageblit(struct fb_info *info, const struct fb_image *image) if (image->depth == 1) { // used for font data - dst = (unsigned long *) - ((unsigned long)info->screen_base & ~(BYTES_PER_LONG - 1)); - dst_idx = ((unsigned long)info->screen_base & (BYTES_PER_LONG - 1)) * 8; - dst_idx += dy * par->next_line * 8 + dx; src = image->data; pitch = (image->width + 7) / 8; while (height--) { -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists