lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Jul 2014 14:31:54 +0200 From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> To: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Tomi Valkeinen <tomi.valkeinen@...com> Cc: Rickard Strandqvist <rickard.strandqvist@...ymobile.com>, Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>, Jingoo Han <jg1.han@...sung.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Rob Clark <robdclark@...il.com>, Daniel Vetter <daniel.vetter@...ll.ch>, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] video: fbdev: msm: mddi.c: Cleaning up variable that is never used From: Rickard Strandqvist <rickard.strandqvist@...ymobile.com> Variable ar assigned a value that is never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> --- drivers/video/fbdev/msm/mddi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/msm/mddi.c b/drivers/video/fbdev/msm/mddi.c index e0f8011..d65ff75a 100644 --- a/drivers/video/fbdev/msm/mddi.c +++ b/drivers/video/fbdev/msm/mddi.c @@ -257,12 +257,12 @@ static irqreturn_t mddi_isr(int irq, void *data) struct msm_mddi_client_data *cdata = data; struct mddi_info *mddi = container_of(cdata, struct mddi_info, client_data); - uint32_t active, status; + uint32_t active; spin_lock(&mddi->int_lock); active = mddi_readl(INT); - status = mddi_readl(STAT); + mddi_readl(STAT); mddi_writel(active, INT); @@ -548,7 +548,6 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg) struct mddi_llentry *ll; struct mddi_register_access *ra; struct reg_read_info ri; - unsigned s; int retry_count = 2; unsigned long irq_flags; @@ -572,7 +571,7 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg) ll->next = 0; ll->reserved = 0; - s = mddi_readl(STAT); + mddi_readl(STAT); ri.reg = reg; ri.status = -1; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists