lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sat, 5 Jul 2014 16:04:22 +0200
From:	Geert Uytterhoeven <>
To:	Rickard Strandqvist <>
Cc:	Jean-Christophe Plagniol-Villard <>,
	Tomi Valkeinen <>,
	Rickard Strandqvist <>,
	Jingoo Han <>,
	Daniel Vetter <>,
	Joe Perches <>,
	Sachin Kamat <>,
	Linux Fbdev development list <>,
	"" <>
Subject: Re: [PATCH] video: fbdev: amifb.c: Cleaning up variable that is never used

On Sat, Jul 5, 2014 at 2:13 PM, Rickard Strandqvist
<> wrote:
> From: Rickard Strandqvist <>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
> This was found using a static code analysis program called cppcheck
> Signed-off-by: Rickard Strandqvist <>

Acked-by: Geert Uytterhoeven <>

> --- a/drivers/video/fbdev/amifb.c
> +++ b/drivers/video/fbdev/amifb.c
> @@ -1124,7 +1124,6 @@ static int ami_decode_var(struct fb_var_screeninfo *var, struct amifb_par *par,
>  {
>         u_short clk_shift, line_shift;
>         u_long maxfetchstop, fstrt, fsize, fconst, xres_n, yres_n;
> -       u_int htotal, vtotal;

These became unused by commit 3161986224a3faa8ccca3e665b7404d81e7ee3cf
Author: Geert Uytterhoeven <>
Date:   Wed Dec 13 00:35:54 2006 -0800

    [PATCH] fbdev: remove references to non-existent fbmon_valid_timings()

    Remove references to non-existent fbmon_valid_timings()

    Signed-off-by: Geert Uytterhoeven <>
    Cc: James Simmons <>
    Signed-off-by: Andrew Morton <>
    Signed-off-by: Linus Torvalds <>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists