linux-kernel - Re: [PATCH] video: fbdev: amifb.c: Cleaning up variable that is never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 5 Jul 2014 16:04:22 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Rickard Strandqvist <rickard.strandqvist@...ymobile.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Joe Perches <joe@...ches.com>,
	Sachin Kamat <sachin.kamat@...aro.org>,
	Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] video: fbdev: amifb.c: Cleaning up variable that is never used

On Sat, Jul 5, 2014 at 2:13 PM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> From: Rickard Strandqvist <rickard.strandqvist@...ymobile.com>
>
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> --- a/drivers/video/fbdev/amifb.c
> +++ b/drivers/video/fbdev/amifb.c
> @@ -1124,7 +1124,6 @@ static int ami_decode_var(struct fb_var_screeninfo *var, struct amifb_par *par,
>  {
>         u_short clk_shift, line_shift;
>         u_long maxfetchstop, fstrt, fsize, fconst, xres_n, yres_n;
> -       u_int htotal, vtotal;

These became unused by commit 3161986224a3faa8ccca3e665b7404d81e7ee3cf
Author: Geert Uytterhoeven <geert@...ux-m68k.org>
Date:   Wed Dec 13 00:35:54 2006 -0800

    [PATCH] fbdev: remove references to non-existent fbmon_valid_timings()

    Remove references to non-existent fbmon_valid_timings()

    Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
    Cc: James Simmons <jsimmons@...radead.org>
    Signed-off-by: Andrew Morton <akpm@...l.org>
    Signed-off-by: Linus Torvalds <torvalds@...l.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/