lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 05 Jul 2014 07:43:08 -0700 From: Randy Dunlap <rdunlap@...radead.org> To: Nicholas Krause <xerofoify@...il.com>, ralf@...ux-mips.org CC: jchandra@...adcom.com, blogic@...nwrt.org, linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mips: Add #ifdef in file bridge.h On 07/04/2014 07:50 PM, Nicholas Krause wrote: > This patch addes a #ifdef __ASSEMBLY__ in order to check if this part > of the file is configured to fix this #ifdef block in bridge.h for mips. > > Signed-off-by: Nicholas Krause <xerofoify@...il.com> > --- > arch/mips/include/asm/netlogic/xlp-hal/bridge.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/include/asm/netlogic/xlp-hal/bridge.h b/arch/mips/include/asm/netlogic/xlp-hal/bridge.h > index 3067f98..4f315c3 100644 > --- a/arch/mips/include/asm/netlogic/xlp-hal/bridge.h > +++ b/arch/mips/include/asm/netlogic/xlp-hal/bridge.h > @@ -143,7 +143,7 @@ > #define BRIDGE_GIO_WEIGHT 0x2cb > #define BRIDGE_FLASH_WEIGHT 0x2cc > > -/* FIXME verify */ > +#ifdef __ASSEMBLY__ > #define BRIDGE_9XX_FLASH_BAR(i) (0x11 + (i)) > #define BRIDGE_9XX_FLASH_BAR_LIMIT(i) (0x15 + (i)) > > Hi, Where is the corresponding #endif ? The #endif at line 185 goes with the #ifndef __ASSEMBLY__ at line 176. I think that this patch will cause a build error (or at least a warning). Did you test it? -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists