linux-kernel - Re: [PATCH v2 1/4] regulator: act8865: set correct number of regulators in pdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 5 Jul 2014 23:31:23 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Beniamino Galvani <b.galvani@...il.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Wenyou Yang <wenyou.yang@...el.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Heiko Stuebner <heiko@...ech.de>, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/4] regulator: act8865: set correct number of
 regulators in pdata

2014-07-05 23:08 GMT+08:00 Axel Lin <axel.lin@...ics.com>:
> 2014-07-05 21:20 GMT+08:00 Beniamino Galvani <b.galvani@...il.com>:
>> act8865_pdata_from_dt() populates the array pdata->regulators with all
>> the regulators and then assigns the field init_data only for the ones
>> actually found in the DT.
>>
>> The patch changes the value assigned to pdata->num_regulators to match
>> the size of the array.
>>
>> Signed-off-by: Beniamino Galvani <b.galvani@...il.com>
>> Tested-by: Wenyou Yang <wenyou.yang@...el.com>
>> ---
>>  drivers/regulator/act8865-regulator.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
>> index f07be36..52d1b6c 100644
>> --- a/drivers/regulator/act8865-regulator.c
>> +++ b/drivers/regulator/act8865-regulator.c
>> @@ -230,7 +230,7 @@ static int act8865_pdata_from_dt(struct device *dev,
>>         if (!pdata->regulators)
>>                 return -ENOMEM;
>>
>> -       pdata->num_regulators = matched;
>> +       pdata->num_regulators = ARRAY_SIZE(act8865_matches);
>>         regulator = pdata->regulators;
>
> You can also include below change as well:
> diff --git a/drivers/regulator/act8865-regulator.c
> b/drivers/regulator/act8865-regulator.c
> index f07be36..9fcedc5 100644
> --- a/drivers/regulator/act8865-regulator.c
> +++ b/drivers/regulator/act8865-regulator.c
> @@ -226,7 +226,7 @@ static int act8865_pdata_from_dt(struct device *dev,
>
>   pdata->regulators = devm_kzalloc(dev,
>   sizeof(struct act8865_regulator_data) *
> - ARRAY_SIZE(act8865_matches), GFP_KERNEL);
> + matched, GFP_KERNEL);
>   if (!pdata->regulators)
>   return -ENOMEM;
Ah.. I misread the code, please forget above comment.
Reviewed-by: Axel Lin <axel.lin@...ics.com>

Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/