linux-kernel - Re: [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove unnecessary null test before debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140705175216.GE26618@google.com>
Date:	Sat, 5 Jul 2014 11:52:16 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Ryan Desfosses <ryan@...fo.org>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove
 unnecessary null test before debugfs_remove

On Sat, Jun 28, 2014 at 11:44:43AM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> "WARNING: debugfs_remove(NULL) is safe this check is probably not required"
> 
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Ryan Desfosses <ryan@...fo.org>
> Cc: linux-pci@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Applied to pci/hotplug for v3.17, thanks!

> ---
>  drivers/pci/hotplug/cpqphp_sysfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/cpqphp_sysfs.c b/drivers/pci/hotplug/cpqphp_sysfs.c
> index 4a392c4..d81648f 100644
> --- a/drivers/pci/hotplug/cpqphp_sysfs.c
> +++ b/drivers/pci/hotplug/cpqphp_sysfs.c
> @@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl)
>  
>  void cpqhp_remove_debugfs_files(struct controller *ctrl)
>  {
> -	if (ctrl->dentry)
> -		debugfs_remove(ctrl->dentry);
> +	debugfs_remove(ctrl->dentry);
>  	ctrl->dentry = NULL;
>  }
>  
> -- 
> 1.8.4.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/