linux-kernel - Re: [PATCH v2 4/4] arm: pxa: add non device-tree timer link to clocksource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5284586.j08GjTMeo6@wuerfel>
Date:	Sat, 05 Jul 2014 20:29:40 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	devicetree@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] arm: pxa: add non device-tree timer link to clocksource

On Saturday 05 July 2014 13:13:01 Robert Jarzmik wrote:
>  EXPORT_SYMBOL(get_clock_tick_rate);
>  
>  /*
> + * For non device-tree builds, keep legacy timer init
> + */
> +extern void pxa_timer_nodt_init(int irq, void __iomem *base,
> +                          unsigned long clock_tick_rate);
> +void pxa_timer_init(void)
> +{
> +       pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x40a00000),
> +                           get_clock_tick_rate());
> +}
> +

I think it would be better to move the extern declaration into 
a new header file, e.g. include/clocksource/pxa.h.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/