lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Jul 2014 23:28:21 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Andrey Utkin <andrey.krieger.utkin@...il.com> Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, acme@...stprotocols.net Subject: Re: [PATCH] appletalk: Set skb with destructor On Sat, Jul 05, 2014 at 07:28:14AM +0300, Andrey Utkin wrote: > See https://bugzilla.kernel.org/show_bug.cgi?id=79441 > ---8<--- > Made changes similar to 0ae89beb283a0db5980d1d4781c7d7be2f2810d6 > Thanks for fixing this bug but the patch description is just a URL and a git hash. Say something like: The sock ref counting is off so there is a kernel panic when you run `atalkd`. See https://bugzilla.kernel.org/show_bug.cgi?id=79441 This fix is similar to 0ae89beb283a ('can: add destructor for self generated skbs') -------------------------- Putting a little information directly in the changelog that it is about refcounting and panics is a useful thing. Also you need to send this to netdev@...r.kernel.org and CC "David S. Miller" <davem@...emloft.net>. Otherwise the patch looks good to my non-expert eye. Please resend to with the updated changelog and CC list. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists