lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 5 Jul 2014 23:28:21 +0300
From:	Dan Carpenter <>
To:	Andrey Utkin <>
Subject: Re: [PATCH] appletalk: Set skb with destructor

On Sat, Jul 05, 2014 at 07:28:14AM +0300, Andrey Utkin wrote:
> See
> ---8<---
> Made changes similar to 0ae89beb283a0db5980d1d4781c7d7be2f2810d6

Thanks for fixing this bug but the patch description is just a URL and a
git hash.  Say something like:

The sock ref counting is off so there is a kernel panic when you run
`atalkd`.  See
This fix is similar to 0ae89beb283a ('can: add destructor for self
generated skbs')


Putting a little information directly in the changelog that it is about
refcounting and panics is a useful thing.

Also you need to send this to and CC
"David S. Miller" <>.  Otherwise the patch looks good
to my non-expert eye.  Please resend to with the updated changelog and
CC list.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists