linux-kernel - Re: [patch] man2/fcntl.2: F_SETPIPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <53B282BA.6010309@gmail.com>
Date:	Tue, 01 Jul 2014 11:43:22 +0200
From:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:	Tomi Salminen <tlsalmin@...il.com>
CC:	mtk.manpages@...il.com, linux-kernel@...r.kernel.org,
	linux-man@...r.kernel.org
Subject: Re: [patch] man2/fcntl.2: F_SETPIPE_SZ returns pipe size, not 0.

On 07/01/2014 11:05 AM, Tomi Salminen wrote:
> Hello.
> 
> I was using F_SETPIPE_SZ and noticed that fcntl was returning the
> pipe size set to it and not zero on success. I checked the kernel
> source, which seemed to return nr_pages * PAGE_SIZE; I made a patch 
> to update the man-page of fcntl, since it specified only F_GETPIPE_SZ
> as returning the pipe size and others zero.
> 
> Attaching patch made on top of commit
> f070e9543a5a7cc600229ee6a3c725804c90de91

Thanks for spotting that, Tomi. I applied a more extensive patch, below.

Cheers,

Michael

--- a/man2/fcntl.2
+++ b/man2/fcntl.2
@@ -1257,9 +1257,7 @@ When allocating the buffer for the pipe,
 the kernel may use a capacity larger than
 .IR arg ,
 if that is convenient for the implementation.
-The
-.B F_GETPIPE_SZ
-operation returns the actual size used.
+The actual capacity that is set is returned as the function result.
 Attempting to set the pipe capacity smaller than the amount
 of buffer space currently used to store data produces the error
 .BR EBUSY .
@@ -1291,7 +1289,7 @@ for traditional
 .B SIGIO
 behavior.
 .TP
-.B F_GETPIPE_SZ
+.BR F_GETPIPE_SZ ", " F_SETPIPE_SZ
 The pipe capacity.
 .TP
 All other commands


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/