[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 07 Jul 2014 09:26:52 +0200
From: Heiko Stübner <heiko@...ech.de>
To: Mark Brown <broonie@...nel.org>
Cc: addy ke <addy.ke@...k-chips.com>, grant.likely@...aro.org,
robh+dt@...nel.org, linux-kernel@...r.kernel.org,
linux-spi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
devicetree@...r.kernel.org, olof@...om.net, hj@...k-chips.com,
kever.yang@...k-chips.com, xjq@...k-chips.com,
huangtao@...k-chips.com, zyw@...k-chips.com, yzq@...k-chips.com,
zhenfu.fang@...k-chips.com, cf@...k-chips.com,
zhangqing@...k-chips.com, wei.luo@...k-chips.com,
Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2 2/2] spi: add driver for Rockchip RK3xxx SoCs integrated SPI
Am Montag, 7. Juli 2014, 08:21:40 schrieb Mark Brown:
> On Mon, Jul 07, 2014 at 09:08:41AM +0200, Heiko Stübner wrote:
> > Am Montag, 7. Juli 2014, 09:42:52 schrieb addy ke:
> > > > Your DT binding defined some additional compatible strings, please add
> > > > those to the driver.
> >
> > citing Mark Rutland (one of the dt maintainers):
> >
> > --
> >
> > That's why I said in addition to the common one. I'd only expect the
> >
> > driver to look for "rockchip,rk3066-spi", but a DTB could have:
> > compatible = "rockchip,rk3188-spi", "rockchip,rk3066-spi";
> >
> > Seeding the DTBs with the extra strings early makes it more likely that
> > we can rely on them later. If we don't happen to need them they only
> > clutter some DTBs.
> >
> > --
> >
> > so it looks like the driver is doing the right thing right now
>
> The driver will work but it's better to list the strings that are
> supported explicitly if only to document that there's nothing specific
> Linux should be doing for them.
ok, makes sense :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists