linux-kernel - Re: [PATCH 1/1] drivers/usb/serial/mos7840.c: remove unnecessary null test before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 7 Jul 2014 10:23:21 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org, Johan Hovold <jhovold@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers/usb/serial/mos7840.c: remove unnecessary
 null test before kfree

On Sat, Jun 28, 2014 at 02:44:09PM +0200, Fabian Frederick wrote:
> Cc: Johan Hovold <jhovold@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-usb@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>

Applied, thanks.

Johan

> ---
>  drivers/usb/serial/mos7840.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
> index 393be56..3d88eef 100644
> --- a/drivers/usb/serial/mos7840.c
> +++ b/drivers/usb/serial/mos7840.c
> @@ -1181,10 +1181,7 @@ static void mos7840_close(struct usb_serial_port *port)
>  	/* Freeing Write URBs */
>  	for (j = 0; j < NUM_URBS; ++j) {
>  		if (mos7840_port->write_urb_pool[j]) {
> -			if (mos7840_port->write_urb_pool[j]->transfer_buffer)
> -				kfree(mos7840_port->write_urb_pool[j]->
> -				      transfer_buffer);
> -
> +			kfree(mos7840_port->write_urb_pool[j]->transfer_buffer);
>  			usb_free_urb(mos7840_port->write_urb_pool[j]);
>  		}
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/