linux-kernel - Re: [PATCH] parisc: Remove sizeof(frame) from call to get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 7 Jul 2014 15:05:50 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
cc:	Nicholas Krause <xerofoify@...il.com>, jejb@...isc-linux.org,
	deller@....de, tiwai@...e.de, dave.anglin@...l.net,
	joe@...ches.com, linux-parisc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: Remove sizeof(frame) from call to get_sigframe

On Mon, 7 Jul 2014, One Thousand Gnomes wrote:

> > This removes the sizeof(frame) from the call to get_sigframe on line
> > 243 in order to fix the call to this function as the sizeof in not
> > needed to call this function.
> 
> If you are going to submit patches then
> 
> - actually read what you are submitting
> 
> - check it actually compiles
> 
> - run it on the system in question and verify your changed code paths are
>   used
> 
> *then* consider submitting it, otherwise all you are doing is wasting
> people's time.

Seconded. Nicholas, this is a third time I've seen patch from you in my 
mailbox that didn't make any sense whatsoever. Please be more careful, 
once certain reputation is gained, it's very difficult to escape it.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/