[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 07 Jul 2014 07:41:32 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Kieran Kunhya <kieran@...hya.com>, axboe@...nel.dk
CC: akpm@...ux-foundation.org, jmoyer@...hat.com, fabf@...net.be,
minchan@...nel.org, linus.walleij@...aro.org,
abhansali@...c-inc.com, gnomes@...rguk.ukuu.org.uk,
jkosina@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: Add support for Sony SxS cards Signed-off-by:
Kieran Kunhya <kieran@...hya.com>
On 07/07/2014 02:53 AM, Kieran Kunhya wrote:
Signed-off-by: should be here,
not in the Subject line.
> ---
> drivers/block/Kconfig | 9 +
> drivers/block/Makefile | 1 +
> drivers/block/sxs.c | 491 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 501 insertions(+)
> create mode 100644 drivers/block/sxs.c
>
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 014a1cf..50ed13e 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -356,6 +356,15 @@ config BLK_DEV_SX8
>
> Use devices /dev/sx8/$N and /dev/sx8/$Np$M.
>
> +config BLK_DEV_SXS
> + tristate "Sony SxS card support"
> + depends on PCI
> + ---help---
> + Saying Y or M here will enable support for reading
> + from Sony SxS cards.
> +
> + It creates a device called /dev/sxs
> +
Use tab to indent tristate, depends, and help.
Use tab + 2 spaces to indent the help text.
> config BLK_DEV_RAM
> tristate "RAM block device support"
> ---help---
> diff --git a/drivers/block/Makefile b/drivers/block/Makefile
> index 02b688d..1e10fb6 100644
> --- a/drivers/block/Makefile
> +++ b/drivers/block/Makefile
> @@ -33,6 +33,7 @@ obj-$(CONFIG_VIRTIO_BLK) += virtio_blk.o
>
> obj-$(CONFIG_BLK_DEV_SX8) += sx8.o
> obj-$(CONFIG_BLK_DEV_HD) += hd.o
> +obj-$(CONFIG_BLK_DEV_SXS) += sxs.o
Use tab(s) here ^^^^^^
not spaces.
>
> obj-$(CONFIG_XEN_BLKDEV_FRONTEND) += xen-blkfront.o
> obj-$(CONFIG_XEN_BLKDEV_BACKEND) += xen-blkback/
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists