lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 7 Jul 2014 16:02:29 +0000
From:	Matthew Garrett <matthew.garrett@...ula.com>
To:	"bhelgaas@...gle.com" <bhelgaas@...gle.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"swarren@...dia.com" <swarren@...dia.com>,
	"vidyas@...dia.com" <vidyas@...dia.com>,
	"thierry.reding@...il.com" <thierry.reding@...il.com>,
	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"kthota@...dia.com" <kthota@...dia.com>,
	"nagananda.chumbalkar@...com" <nagananda.chumbalkar@...com>
Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

On Sat, 2014-07-05 at 13:02 -0600, Bjorn Helgaas wrote:
> > Rafael, Matthew, any comments?  We have vacillated on this before and
> > the web is already pretty tangled.
> > 
> > Vidya, can you give more details about the bug fixed by this change?
> > What's the scenario?  Are we resuming and the device is powered up but
> > ASPM isn't enabled?  Maybe you could collect more details in a
> > http://bugzilla.kernel.org report?

I believe that's the case. The proposed change would fix it but isn't
really terribly clean - I think it would be more readable to split this
into multiple functions.

-- 
Matthew Garrett <matthew.garrett@...ula.com>

Powered by blists - more mailing lists